Development talk:Grade settings modules

1. I strongly disagree with creating a new table to store grade settings. (You will note, for example, that the group settings are stored in the course_modules table, not in a separate table)

There is already another database table that stores grade settings for each module, the grade_items table. That contains things like max grade and decimal points. The whole point of changing things is to avoid duplicating those settings in other tables.

2. If you look at the quiz, you will notice that the UI for mdl_quiz.grade is not in mod/quiz/mod_form.php. It is only mod/quiz/edit.php, for various reasons, most of them good. How will that sort of thing be handled in your new system?

3. I though an important part of this change was getting rid of tables like quiz_grades, and the assignment_submissions.grade, and other places we store an overall grade for the activity in module-specific tables. Also having centralised code for outputting grading UI for those modules that need it (the plan in to split assignment into several specific modules, as we did with resource, without duplicating code. This sort of grading UI is not relevant to quiz, unless we choose to let teacher manually override the total grade in the quiz UI, as well as in the gradebook). I would like to see this part specified too, before you start changing anything.

4. The quiz.grademethod seems pretty quiz-specific to me. I don't think it is relevant to this proposal, and quiz.penalty is totally quiz-specific.

Sorry to disagree with basically everything you have written, Andrew, but it looks to me that the problem you are trying to solve was not explained to you properly.--Tim Hunt 16:23, 8 February 2010 (UTC)