Talk:Grade settings modules

1. I strongly disagree with creating a new table to store grade settings. (You will note, for example, that the group settings are stored in the course_modules table, not in a separate table)

There is already another database table that stores grade settings for each module, the grade_items table. That contains things like max grade and decimal points. The whole point of changing things is to avoid duplicating those settings in other tables.

2. If you look at the quiz, you will notice that the UI for mdl_quiz.grade is not in mod/quiz/mod_form.php. It is only mod/quiz/edit.php, for various reasons, most of them good. How will that sort of thing be handled in your new system?

3. I though an important part of this change was getting rid of tables like quiz_grades, and the assignment_submissions.grade, and other places we store an overall grade for the activity in module-specific tables. Also having centralised code for outputting grading UI for those modules that need it (the plan in to split assignment into several specific modules, as we did with resource, without duplicating code. This sort of grading UI is not relevant to quiz, unless we choose to let teacher manually override the total grade in the quiz UI, as well as in the gradebook). I would like to see this part specified too, before you start changing anything.

4. The quiz.grademethod seems pretty quiz-specific to me. I don't think it is relevant to this proposal, and quiz.penalty is totally quiz-specific.

Sorry to disagree with basically everything you have written, Andrew, but it looks to me that the problem you are trying to solve was not explained to you properly.--Tim Hunt 16:23, 8 February 2010 (UTC)

Don't worry about disagreeing with me. I guess that's part of the point of writing these documents before. Better I found out I'm on the wrong track now :)

1. Adding columns to the course_modules table does seem to be more sensible than adding another table that will then have to be joined most of the time.

2. When you create a quiz it takes to page at a url like course/modedit.php?add=quiz&type=&course=3&section=1&return=0 that loads a form from mod/quiz/mod_form.php. After the quiz is created editing it takes you to mod/quiz/edit.php I'm guessing there should be a button/link from there that takes you back to course/modedit.php to access the settings. mod/quiz/edit.php is currently a bit broken so I'm not sure what it's meant to look like.

3. The shift towards a unified grading interface (which will deal with shifting the grades) is a separate document. https://docs.moodle.org/en/Development:Grading_interface_2.0 That document has received even less attention than this one (from me and others). I was intending on getting this one hammered out first to reduce the amount of rewriting I have to do. First step is grading related settings. Second step is grades themselves.

4. Yeah, that is pretty quiz specific. It can stay where it is in the quiz module.

I'll wait for you to comment again before I update the document itself to reflect the above. --Andrew Davis 03:02, 9 February 2010 (UTC)

Ok, I've taken out the unnecessary new table. the grade_items table will be used instead. --Andrew Davis 09:00, 10 February 2010 (UTC)