Development:Weekly Code Review - Revision history

Jmouneyrac at 08:36, 22 September 2008

2008-09-22T08:36:14Z

← Older revision		Revision as of 08:36, 22 September 2008
Line 53:		Line 53:

	[[Category:Developer\|Weekly Code Review]]		[[Category:Developer\|Weekly Code Review]]
			[[Category:Quality Assurance]]

Dougiamas: /* Don't check any new fixes into CVS */

2008-05-28T11:07:27Z

Don't check any new fixes into CVS

← Older revision		Revision as of 11:07, 28 May 2008
Line 8:		Line 8:

	HEAD is OK, but please avoid new fixes in all STABLE branches unless they are definitely definitely not going to cause new bugs ;-)		HEAD is OK, but please avoid new fixes in all STABLE branches unless they are definitely definitely not going to cause new bugs ;-)


	===Find bugs to test===		===Find bugs to test===

Dougiamas at 11:07, 28 May 2008

2008-05-28T11:07:13Z

← Older revision		Revision as of 11:07, 28 May 2008
Line 4:		Line 4:

	==Every Tuesday==		==Every Tuesday==

			===Don't check any new fixes into CVS===

			HEAD is OK, but please avoid new fixes in all STABLE branches unless they are definitely definitely not going to cause new bugs ;-)


	===Find bugs to test===		===Find bugs to test===

Dougiamas at 14:21, 1 April 2008

2008-04-01T14:21:38Z

← Older revision		Revision as of 14:21, 1 April 2008
Line 28:		Line 28:
	* Post new comments (or talk on Moodle HQ) if you need clarification		* Post new comments (or talk on Moodle HQ) if you need clarification

	===~~If you find a problem~~===		===Deal with any problems===

	* Post a comment on the bug with details (preferably including patch!)		* Post a comment on the bug with details (preferably including patch!)

Tsala: category

2008-04-01T12:11:32Z

category

← Older revision		Revision as of 12:11, 1 April 2008
Line 9:		Line 9:
	All developers and testers should be looking at:		All developers and testers should be looking at:

	Moodle 1.9 stable: [http://tracker.moodle.org/secure/IssueNavigator.jspa?mode=hide&requestId=10565 1.9.x Needs QA review]		Moodle 1.9 stable: [http://tracker.moodle.org/secure/IssueNavigator.jspa?mode=hide&requestId=10565 1.9.x Needs QA review]

	(Make sure you can see the QA Assigned column)		(Make sure you can see the QA Assigned column)
Line 15:		Line 15:
	Grab any bug that:		Grab any bug that:

	* is from the last week		* Is from the last week
	* ~~you~~ did not fix		* You did not fix
	* ~~does~~ not have a QA assignee yet		* Does not have a QA assignee yet

	and claim it by editing the bug to add your name as QA Assignee.		and claim it by editing the bug to add your name as QA Assignee.


	===Test the fix===		===Test the fix===
Line 33:		Line 32:
	* Post a comment on the bug with details (preferably including patch!)		* Post a comment on the bug with details (preferably including patch!)
	* Reopen the bug		* Reopen the bug
	* If it looks like the original developer isn't seeing it, reassign to Eloy Lafuente for triage.		* If it looks like the original developer isn't seeing it, reassign to Eloy Lafuente for [[Development:Bug triage\|triage]]
	* If the fix is obvious and you have CVS access, fix it yourself.		* If the fix is obvious and you have CVS access, fix it yourself

	===Mark the fix as reviewed===		===Mark the fix as reviewed===
Line 44:		Line 43:

	* The download site will automatically tag the whole current stable codebase (eg MOODLE_19_WEEKLY) and then build download packages		* The download site will automatically tag the whole current stable codebase (eg MOODLE_19_WEEKLY) and then build download packages

			==See also==

			*Using Moodle [http://moodle.org/mod/forum/discuss.php?d=93474 Tuesday Code Reviews] forum discussion

			[[Category:Developer\|Weekly Code Review]]

Skodak: /* Mark the fix as reviewed */

2008-04-01T07:30:54Z

Mark the fix as reviewed

← Older revision		Revision as of 07:30, 1 April 2008
Line 39:		Line 39:

	* When you are satisfied the bug is correctly fixed, simply change the status from Resolved to Closed		* When you are satisfied the bug is correctly fixed, simply change the status from Resolved to Closed
			* If you committed any fix, let somebody else review it again - do not Close it yourself

	==Every Wednesday==		==Every Wednesday==

	* The download site will automatically tag the whole current stable codebase (eg MOODLE_19_WEEKLY) and then build download packages		* The download site will automatically tag the whole current stable codebase (eg MOODLE_19_WEEKLY) and then build download packages

Scyrma: /* Test the fix */

2008-04-01T03:42:23Z

Test the fix

← Older revision		Revision as of 03:42, 1 April 2008
Line 25:		Line 25:

	* Read the comments		* Read the comments
	* Look at the patch ~~atatched~~ to the tracker		* Look at the patch attached to the tracker
	* Try the feature out to make sure it works as advertised		* Try the feature out to make sure it works as advertised
	* Post new comments (or talk on Moodle HQ) if you need clarification		* Post new comments (or talk on Moodle HQ) if you need clarification

Dougiamas: /* Every Tuesday */

2008-04-01T03:25:49Z

Every Tuesday

← Older revision		Revision as of 03:25, 1 April 2008
Line 5:		Line 5:
	==Every Tuesday==		==Every Tuesday==

	~~Everyone~~ should ~~look~~ at ~~the latest bugs needing review~~:		===Find bugs to test===

			All developers and testers should be looking at:

	Moodle 1.9 stable: [http://tracker.moodle.org/secure/IssueNavigator.jspa?mode=hide&requestId=10565 1.9.x Needs QA review]		Moodle 1.9 stable: [http://tracker.moodle.org/secure/IssueNavigator.jspa?mode=hide&requestId=10565 1.9.x Needs QA review]
Line 27:		Line 29:
	* Post new comments (or talk on Moodle HQ) if you need clarification		* Post new comments (or talk on Moodle HQ) if you need clarification

			===If you find a problem===

			* Post a comment on the bug with details (preferably including patch!)
			* Reopen the bug
			* If it looks like the original developer isn't seeing it, reassign to Eloy Lafuente for triage.
			* If the fix is obvious and you have CVS access, fix it yourself.

	===Mark the fix as reviewed===		===Mark the fix as reviewed===

	* When you are satisfied, simply change the status from Resolved to Closed		* When you are satisfied the bug is correctly fixed, simply change the status from Resolved to Closed

	==Every Wednesday==		==Every Wednesday==

	* The download site will automatically tag the whole current stable codebase (eg MOODLE_19_WEEKLY) and then build download packages		* The download site will automatically tag the whole current stable codebase (eg MOODLE_19_WEEKLY) and then build download packages

Dougiamas: /* Every Tuesday */

2008-04-01T03:20:44Z

Every Tuesday

← Older revision		Revision as of 03:20, 1 April 2008
Line 5:		Line 5:
	==Every Tuesday==		==Every Tuesday==

	Everyone should look at ~~this list~~: [http://tracker.moodle.org/secure/IssueNavigator.jspa?mode=hide&requestId=10565 1.9.x Needs QA review]		Everyone should look at the latest bugs needing review:

			Moodle 1.9 stable: [http://tracker.moodle.org/secure/IssueNavigator.jspa?mode=hide&requestId=10565 1.9.x Needs QA review]

	(Make sure you can see the QA Assigned column)		(Make sure you can see the QA Assigned column)

	Grab any bug ~~without~~ a QA assignee ~~from the past week,~~ and claim it by editing the bug to add your name ~~there~~.		Grab any bug that:

			* is from the last week
			* you did not fix
			* does not have a QA assignee yet

			and claim it by editing the bug to add your name as QA Assignee.


Line 17:		Line 25:
	* Look at the patch atatched to the tracker		* Look at the patch atatched to the tracker
	* Try the feature out to make sure it works as advertised		* Try the feature out to make sure it works as advertised
	* Post new comments if you need clarification		* Post new comments (or talk on Moodle HQ) if you need clarification


Line 23:		Line 31:

	* When you are satisfied, simply change the status from Resolved to Closed		* When you are satisfied, simply change the status from Resolved to Closed


	==Every Wednesday==		==Every Wednesday==

	* The download site will automatically tag the whole current stable codebase (eg MOODLE_19_WEEKLY) and then build download packages		* The download site will automatically tag the whole current stable codebase (eg MOODLE_19_WEEKLY) and then build download packages

Dougiamas at 03:07, 1 April 2008

2008-04-01T03:07:09Z

New page

Moodle has a weekly process of code review in the stable branches to help improve the quality of stable packages and to help detect any regressions that may have occurred in stable code.

Here is the process for testers and developers:

==Every Tuesday==

Everyone should look at this list: [http://tracker.moodle.org/secure/IssueNavigator.jspa?mode=hide&requestId=10565 1.9.x Needs QA review]

(Make sure you can see the QA Assigned column)

Grab any bug without a QA assignee from the past week, and claim it by editing the bug to add your name there.

===Test the fix===

* Read the comments
* Look at the patch atatched to the tracker
* Try the feature out to make sure it works as advertised
* Post new comments if you need clarification

===Mark the fix as reviewed===

* When you are satisfied, simply change the status from Resolved to Closed

==Every Wednesday==

* The download site will automatically tag the whole current stable codebase (eg MOODLE_19_WEEKLY) and then build download packages