Note:

If you want to create a new page for developers, you should create it on the Moodle Developer Resource site.

Talk:Javascript-interface for repeat elements function: Difference between revisions

From MoodleDocs
(New page: I already told you what I think about this page: # one screenshot is quite enought for what you done, it isn't necessary to add screenshot to every alert message box - this is not Microsof...)
 
mNo edit summary
Line 1: Line 1:
I already told you what I think about this page:
# "Where it will be" - don't think full list is necessary, you may just list some places. Core function should work anywhere it called, calling isn't you problems.
# one screenshot is quite enought for what you done, it isn't necessary to add screenshot to every alert message box - this is not Microsoft User Manual, just a sentence that this will be done is enought;
# I don't think using AJAX to add new blanks is a good idea. Why don't just add them using javascript on the page, creating new HTML-elements (you'll need a hidden empty blank somewhere ready to copying) and changing hidden element with the number of blanks? The server is stateless, it won't find anything strange when the modified form will be submitted.
# one more screenshot needed to show how it would look when blank contains exactly one string, without any fieldsets around it
# Last sentences about deleting/moving isn't necessary, you are talking with the smart people, they sure know what those icon do. At least make pictures smaller - or just delete all this.
# write out thoroughtly, which field types you would check for been non-empty when deleting
# Still nothing about preserving original numbers of the blanks and proposed changes in the repeat_elements interface to set $prefix instead of two existing (and one new) element names...
# write how you would remember initial positions of the blanks and return them after editing
# I don't see any "restore order" button on the screenshots, I also don't sure why it is necessary while it definitely wouldn't be easy thing to implement. If you implement all other things that will be quite enought.
# and mind you spelling, correct "choise" all over the place.
--[[User:Oleg Sychev|Oleg Sychev]] 21:27, 2 October 2010 (UTC)
Now I am wondering why it still not done...
--[[User:Oleg Sychev|Oleg Sychev]] 13:21, 1 October 2010 (UTC)

Revision as of 21:27, 2 October 2010

  1. "Where it will be" - don't think full list is necessary, you may just list some places. Core function should work anywhere it called, calling isn't you problems.
  2. I don't think using AJAX to add new blanks is a good idea. Why don't just add them using javascript on the page, creating new HTML-elements (you'll need a hidden empty blank somewhere ready to copying) and changing hidden element with the number of blanks? The server is stateless, it won't find anything strange when the modified form will be submitted.
  3. Last sentences about deleting/moving isn't necessary, you are talking with the smart people, they sure know what those icon do. At least make pictures smaller - or just delete all this.
  4. Still nothing about preserving original numbers of the blanks and proposed changes in the repeat_elements interface to set $prefix instead of two existing (and one new) element names...
  5. I don't see any "restore order" button on the screenshots, I also don't sure why it is necessary while it definitely wouldn't be easy thing to implement. If you implement all other things that will be quite enought.

--Oleg Sychev 21:27, 2 October 2010 (UTC)