Talk:Authentication plugins: Difference between revisions
(New page: To make the title and description translations of the plugin work, you must also create the class constructor.) |
Ryan Foster (talk | contribs) |
||
| (2 intermediate revisions by the same user not shown) | |||
| Line 1: | Line 1: | ||
To make the title and description translations of the plugin work, you must also create the class constructor. | To make the title and description translations of the plugin work, you must also create the class constructor. | ||
== prevent_local_passwords() documentation == | |||
The current documentation states: | |||
:: Indicates if password hashes should be stored in local moodle database. | |||
The code in auth/none has no comments regarding this method. Am I to assume that using "return false" allows password hashes to be stored in Moodle's database and "return true" ''prevents'' password hashes from being stored in Moodle's database? | |||
--[[User:Ryan Foster|Ryan Foster]] ([[User talk:Ryan Foster|talk]]) 04:21, 18 September 2013 (WST) | |||
: I found that there were comments in lib/authlib.php. | |||
: --[[User:Ryan Foster|Ryan Foster]] ([[User talk:Ryan Foster|talk]]) 04:01, 24 September 2013 (WST) | |||
== Overriding functions == | |||
It seems there is some ambiguity about which functions should be overridden. For example, I'd imagine that get_title() and get_description() are not meant to be overridden, but there appears to be nothing stopping a developer from doing so. Should this be marked here in the docs, commented in the code, or disallowed by making such functions "final"? | |||
--[[User:Ryan Foster|Ryan Foster]] ([[User talk:Ryan Foster|talk]]) 06:50, 21 September 2013 (WST) | |||
Latest revision as of 20:01, 23 September 2013
To make the title and description translations of the plugin work, you must also create the class constructor.
prevent_local_passwords() documentation
The current documentation states:
- Indicates if password hashes should be stored in local moodle database.
The code in auth/none has no comments regarding this method. Am I to assume that using "return false" allows password hashes to be stored in Moodle's database and "return true" prevents password hashes from being stored in Moodle's database?
--Ryan Foster (talk) 04:21, 18 September 2013 (WST)
- I found that there were comments in lib/authlib.php.
- --Ryan Foster (talk) 04:01, 24 September 2013 (WST)
Overriding functions
It seems there is some ambiguity about which functions should be overridden. For example, I'd imagine that get_title() and get_description() are not meant to be overridden, but there appears to be nothing stopping a developer from doing so. Should this be marked here in the docs, commented in the code, or disallowed by making such functions "final"?
--Ryan Foster (talk) 06:50, 21 September 2013 (WST)
