Hardening new Roles system

New roles add great freedom when assigning capabilities to students. The problem might arise when students are assigned permission that allows adding of content that is not cleaned before display - such as editting Resources, adding activities, etc. They could then use any type of XSS attack to gain full administrative access quite easily.

The solution has two parts: educate admins and teachers about the risks associated with each capability and optionally allow central management of risks.

Risk bitmask in capabilities

Add risk bitmask field to each capability. Each bit indicates presence of different risk associated with given capability.

Basic risks

• CAP_RISK_SPAM - user can add visible content to site, send messages to other users; originally protected by !isguest()
• CAP_RISK_PERSONAL - access to private personal information - ex: backups with user details, non public information in profile (hidden email), etc.; originally protected by isteacher()
• CAP_RISK_XSS - user can submit content that is not cleaned (both HTML with active content and unprotected files); originally protected by isteacher()
• CAP_RISK_ADMIN - user can change global configuration, actions are missing sanity checks, changing trust bitmasks
• ??

In default configuration Guest role should have only capabilities without risks, Student roles also SPAM, Teacher roles PERSONAL and XSS too. Admins have all capabilitites by default.

Implementation

• add new LONGINT column riskbitmask to table capabilities (DONE)
• define risks and assign them to capabilities in mod/xxx/db/access.php
• link wiki pages with explanation to each risk from capabilities page
• allow risk based filtering of capabilities admin/roles/manage.php (optional)

The user interface will be minimal, icons and maybe colors indicating each risk together with description links which we need anyway. Developers are deciding about the risks, the risk assignment would is hardcoded in access.php description file, no GUI needed.

Benefits

1. proper documentation of risks associated with capabilities, easy to explain
2. solid foundation for regular code audits (mainly XSS prevention and personal information disclosure)

User trust bitmask

Indicate what kind of trust each user has. Match the risk bitmask of capability and user trust bitmask in both has_capability() and require_capability().

Implementation

• add new LONGINT column trustbitmask to user table
• add capability moodle/site:managetrustbitmasks with CAP_RISK_ADMIN risk
• add trust checks to has_capability() and require_capability()
• add GUI
  • switch in global configuration to enable trust bitmask checking
  • preseting of trust bitmask for new users
  • changing of trust bitmasks
  • add trust bitmask setting to user/edit.php
  • request trust level change form - something like new course request (optional)
• fix upgrade to assign trust bitmaps based on original teacher or administrator rights
• patch user import script and synchronizations (optional)

Benefits

1. This part is optional and can be implemented later.
2. Trust manager or admin has full control over potentially dangerous capabilities - it is necessary for large sites (or connected sites in the future).
3. Trust bitmask mechanism can be turned off by single configuration switch (both GUI and checks) - needed for small insecure workshop sites.
4. General protection against future bugs in role and capability framework or user errors when configuring roles.

Note: trusttext moved to its own page at Trusttext cleaning bypass