Talk:CSS Coding Style - Revision history

Poltawski at 08:27, 29 July 2016

2016-07-29T08:27:33Z

← Older revision		Revision as of 08:27, 29 July 2016
Line 1:		Line 1:
	<p class="note">Note: Please avoid using this talk page to propose changes to the coding style. Instead file a coding style bug. See the forum discussion [http://moodle.org/mod/forum/discuss.php?d=202406 Using Moodle: Proposing changes to moodle coding style] for more details.</p>		<p class="note">Note: Please avoid using this talk page to propose changes to the coding style. Instead [https://tracker.moodle.org/secure/CreateIssueDetails!init.jspa?pid=10020&issuetype=1&components=12132&summary=CSS%20coding%20style%20change file a coding style bug]. See the forum discussion [http://moodle.org/mod/forum/discuss.php?d=202406 Using Moodle: Proposing changes to moodle coding style] for more details.</p>

Poltawski at 08:19, 29 July 2016

2016-07-29T08:19:10Z

← Older revision		Revision as of 08:19, 29 July 2016
Line 1:		Line 1:
	Please ~~do not use~~ this talk page ~~and instead use this~~ forum ~~thread for~~ discussion~~: https~~://moodle.org/mod/forum/discuss.php?d=~~275476~~		<p class="note">Note: Please avoid using this talk page to propose changes to the coding style. Instead file a coding style bug. See the forum discussion [http://moodle.org/mod/forum/discuss.php?d=202406 Using Moodle: Proposing changes to moodle coding style] for more details.</p>

Poltawski: Poltawski moved page Talk:CSS coding style to Talk:CSS Coding Style: Proper capitalisation of titles

2016-07-29T08:07:31Z

Poltawski moved page Talk:CSS coding style to Talk:CSS Coding Style: Proper capitalisation of titles

← Older revision	Revision as of 08:07, 29 July 2016
(No difference)

Poltawski at 07:34, 21 November 2014

2014-11-21T07:34:23Z

← Older revision	Revision as of 07:34, 21 November 2014
Line 1:	Line 1:
		Please do not use this talk page and instead use this forum thread for discussion: https://moodle.org/mod/forum/discuss.php?d=275476

Poltawski: Clearing discussion comments in preparation for RFC and new draft

2014-11-21T06:59:37Z

Clearing discussion comments in preparation for RFC and new draft

← Older revision		Revision as of 06:59, 21 November 2014
Line 1:		Line 1:

	~~== Removed "unless it is the last rule in the list of CSS mark-up." ==~~

	~~https://docs.moodle.org/dev/index.php?title=CSS_coding_style&diff=42786&oldid=42785~~

	I don't think this made any sense. Possibly someone was getting colons and semi-colons mixed up? You always need the colon, and while you can leave the semi-colon off the last one, and it's a common minification technique, that's something the CSS minifier should take care of automatically (note to myself, should really check the Moodle minifier does this, but I think it does). Otherwise it introduces noise into the diffs since you need to change two lines if you add or remove the line at the end and gives the person writing the CSS a weird, subtle manual rule to be aware of. (In PHP we recommend the opposite and add a comma at the end of arrays even though it's not necessary.)

	~~== Leave one line between blocks ==~~

	~~https://docs.moodle.org/dev/index.php?title=CSS_coding_style&diff=42785&oldid=42784~~

	Changed this from recommending no empty line between CSS blocks, except for signalling sections to a standard one line between all blocks. The old rule is hard to enforce or check automatically since the tool won't know about what is and isn't a section.

	I also checked the Wordpress CSS guides that this was based on and they (at least currently) say "Add two blank lines between sections and one blank line between blocks in a section." which seems a bit more reasonable (I think one line is fairly standard) but still suffers from not being able to run a formatter or linter over the file without losing info. If people want to have section breaks they should use comments, which are covered later in the doc.

	~~== A few questions ==~~


	~~A few questions about these style guidelines, as they seem a bit outdated:~~
	# Do we need to restrict color settings to only HEX? This probably made sense when there was only HEX & RGB, but we now have really cool stuff like HSLA which is supported in all the browsers we support except IE8. It's also very easy to provide fallback to HEX:
	~~<code>~~

	~~.selector {~~
	~~background-color: #hex;~~
	~~background-color: hsla(170, 50%, 45%, 1);~~
	}

	~~</code>~~
	# For many properties, browser prefixes are no longer needed for our supported browsers. Shouldn't we be recommending that browser prefixes be added for supported browsers which need them, only? (Also, to make sure there is a background-color fallback for things like gradients?)
	# What about !important being a bad thing? If you can't override existing rules without !important, that indicates that existing selectors are too aggressive (usually using IDs rather than classes and elements).
	~~# How about we recommend OOCSS and where you can't use it request classes added to Moodle's markup so you can?~~

Bawjaws: Some reasoning for my recent changes

2013-10-30T10:07:08Z

Some reasoning for my recent changes

← Older revision		Revision as of 10:07, 30 October 2013
Line 1:		Line 1:

			== Removed "unless it is the last rule in the list of CSS mark-up." ==

			https://docs.moodle.org/dev/index.php?title=CSS_coding_style&diff=42786&oldid=42785

			I don't think this made any sense. Possibly someone was getting colons and semi-colons mixed up? You always need the colon, and while you can leave the semi-colon off the last one, and it's a common minification technique, that's something the CSS minifier should take care of automatically (note to myself, should really check the Moodle minifier does this, but I think it does). Otherwise it introduces noise into the diffs since you need to change two lines if you add or remove the line at the end and gives the person writing the CSS a weird, subtle manual rule to be aware of. (In PHP we recommend the opposite and add a comma at the end of arrays even though it's not necessary.)

			== Leave one line between blocks ==

			https://docs.moodle.org/dev/index.php?title=CSS_coding_style&diff=42785&oldid=42784

			Changed this from recommending no empty line between CSS blocks, except for signalling sections to a standard one line between all blocks. The old rule is hard to enforce or check automatically since the tool won't know about what is and isn't a section.

			I also checked the Wordpress CSS guides that this was based on and they (at least currently) say "Add two blank lines between sections and one blank line between blocks in a section." which seems a bit more reasonable (I think one line is fairly standard) but still suffers from not being able to run a formatter or linter over the file without losing info. If people want to have section breaks they should use comments, which are covered later in the doc.

			== A few questions ==


	A few questions about these style guidelines, as they seem a bit outdated:		A few questions about these style guidelines, as they seem a bit outdated:
	# Do we need to restrict color settings to only HEX? This probably made sense when there was only HEX & RGB, but we now have really cool stuff like HSLA which is supported in all the browsers we support except IE8. It's also very easy to provide fallback to HEX:		# Do we need to restrict color settings to only HEX? This probably made sense when there was only HEX & RGB, but we now have really cool stuff like HSLA which is supported in all the browsers we support except IE8. It's also very easy to provide fallback to HEX:

Aegroshek at 20:12, 24 January 2013

2013-01-24T20:12:14Z

← Older revision		Revision as of 20:12, 24 January 2013
Line 1:		Line 1:
	A few questions about these style guidelines, as they seem a bit outdated:		A few questions about these style guidelines, as they seem a bit outdated:
	1) Do we need to restrict color settings to only HEX? This probably made sense when there was only HEX & RGB, but we now have really cool stuff like HSLA which is supported in all the browsers we support except IE8. It's also very easy to provide fallback to HEX:		# Do we need to restrict color settings to only HEX? This probably made sense when there was only HEX & RGB, but we now have really cool stuff like HSLA which is supported in all the browsers we support except IE8. It's also very easy to provide fallback to HEX:
	<code>		<code>

Line 9:		Line 9:

	</code>		</code>
	2) For many properties, browser prefixes are no longer needed for our supported browsers. Shouldn't we be recommending that browser prefixes be added for supported browsers which need them, only? (Also, to make sure there is a background-color fallback for things like gradients?)		# For many properties, browser prefixes are no longer needed for our supported browsers. Shouldn't we be recommending that browser prefixes be added for supported browsers which need them, only? (Also, to make sure there is a background-color fallback for things like gradients?)
	3) What about !important being a bad thing? If you can't override existing rules without !important, that indicates that existing selectors are too aggressive (usually using IDs rather than classes and elements).		# What about !important being a bad thing? If you can't override existing rules without !important, that indicates that existing selectors are too aggressive (usually using IDs rather than classes and elements).
	4) How about we recommend OOCSS and where you can't use it request classes added to Moodle's markup so you can?		# How about we recommend OOCSS and where you can't use it request classes added to Moodle's markup so you can?

Aegroshek: Created page with "A few questions about these style guidelines, as they seem a bit outdated: 1) Do we need to restrict color settings to only HEX? This probably made sense when there was only HEX..."

2013-01-24T20:11:34Z

Created page with "A few questions about these style guidelines, as they seem a bit outdated: 1) Do we need to restrict color settings to only HEX? This probably made sense when there was only HEX..."

New page

A few questions about these style guidelines, as they seem a bit outdated:
1) Do we need to restrict color settings to only HEX? This probably made sense when there was only HEX & RGB, but we now have really cool stuff like HSLA which is supported in all the browsers we support except IE8. It's also very easy to provide fallback to HEX:
<code>

.selector {
background-color: #hex;
background-color: hsla(170, 50%, 45%, 1);
}

</code>
2) For many properties, browser prefixes are no longer needed for our supported browsers. Shouldn't we be recommending that browser prefixes be added for supported browsers which need them, only? (Also, to make sure there is a background-color fallback for things like gradients?)
3) What about !important being a bad thing? If you can't override existing rules without !important, that indicates that existing selectors are too aggressive (usually using IDs rather than classes and elements).
4) How about we recommend OOCSS and where you can't use it request classes added to Moodle's markup so you can?