Development:Groups: Difference between revisions
Line 30: | Line 30: | ||
==Group/grouping cloning== | ==Group/grouping cloning== | ||
Cloning or duplicating is UI feature only, it helps to prefill new groups/groupings with existing data. | |||
==Other code cleanup== | ==Other code cleanup== |
Revision as of 07:29, 18 July 2007
Improving the Groups design in Moodle 1.9
Summary of problems:
- Can not define groupings at site level
- Groupings not implemented in modules
- Concept of orphaned groups
- Not integrated into Moodle core
- Unfinished and partially broken code
It would be very hard to improve current code without major refactoring and design changes. --Petr Škoda (škoďák) 02:37, 10 April 2007 (CDT)
Competing proposals
Change groups/groupings relationship
At present both groups and groupings may belong to several courses, you could use one group in several courses and groupings at the same time. This loose relationship of groups and groupings adds too much complexity and is a source of bugs in code.
Solution: Each group and grouping would link the course id directly. Groupings would be only limiting the number of usable groups in activities. This allows free sharing of groups in groupings inside course without potential problems. This idea was proposed by Enrique. See attached db schema.
Benefits:
- fewer tables
- normalized
- simpler SQL
- easier backup/restore implementation
- more compatible with old group implementation in 1.7
Linked groups
maybe in future - it would allow synchronizing of group membership from different courses
Group/grouping cloning
Cloning or duplicating is UI feature only, it helps to prefill new groups/groupings with existing data.
Other code cleanup
Current group code does not follow Moodle coding guide, has several unfinished/broken/obsoleted parts, is not integrated into core, etc. To do:
- integrate setup and upgrade into main lib/db/*.*
- remove columns from groupings table that can be replaced by permissions
- reduce the number of functions, rewrite or fix them, move them into lib/grouplib.php
- rewrite UI in /group/
- implement module and course groupings support, fix all mods to use it (course edit form, mod edit form, etc.)
- fix legacy functions
- documentation
Needed time
1 month for implementation and testing.