Weekly Code Review: Difference between revisions
From MoodleDocs
Helen Foster (talk | contribs) m (category) |
|||
| Line 9: | Line 9: | ||
All developers and testers should be looking at: | All developers and testers should be looking at: | ||
Moodle 1.9 stable: [http://tracker.moodle.org/secure/IssueNavigator.jspa?mode=hide&requestId=10565 1.9.x Needs QA review] | |||
(Make sure you can see the QA Assigned column) | (Make sure you can see the QA Assigned column) | ||
| Line 15: | Line 15: | ||
Grab any bug that: | Grab any bug that: | ||
* | * Is from the last week | ||
* | * You did not fix | ||
* | * Does not have a QA assignee yet | ||
and claim it by editing the bug to add your name as QA Assignee. | and claim it by editing the bug to add your name as QA Assignee. | ||
===Test the fix=== | ===Test the fix=== | ||
| Line 33: | Line 32: | ||
* Post a comment on the bug with details (preferably including patch!) | * Post a comment on the bug with details (preferably including patch!) | ||
* Reopen the bug | * Reopen the bug | ||
* If it looks like the original developer isn't seeing it, reassign to Eloy Lafuente for triage | * If it looks like the original developer isn't seeing it, reassign to Eloy Lafuente for [[Bug triage|triage]] | ||
* If the fix is obvious and you have CVS access, fix it yourself | * If the fix is obvious and you have CVS access, fix it yourself | ||
===Mark the fix as reviewed=== | ===Mark the fix as reviewed=== | ||
| Line 44: | Line 43: | ||
* The download site will automatically tag the whole current stable codebase (eg MOODLE_19_WEEKLY) and then build download packages | * The download site will automatically tag the whole current stable codebase (eg MOODLE_19_WEEKLY) and then build download packages | ||
==See also== | |||
*Using Moodle [http://moodle.org/mod/forum/discuss.php?d=93474 Tuesday Code Reviews] forum discussion | |||
[[Category:Weekly Code Review]] | |||
Revision as of 12:11, 1 April 2008
Moodle has a weekly process of code review in the stable branches to help improve the quality of stable packages and to help detect any regressions that may have occurred in stable code.
Here is the process for testers and developers:
Every Tuesday
Find bugs to test
All developers and testers should be looking at:
Moodle 1.9 stable: 1.9.x Needs QA review
(Make sure you can see the QA Assigned column)
Grab any bug that:
- Is from the last week
- You did not fix
- Does not have a QA assignee yet
and claim it by editing the bug to add your name as QA Assignee.
Test the fix
- Read the comments
- Look at the patch attached to the tracker
- Try the feature out to make sure it works as advertised
- Post new comments (or talk on Moodle HQ) if you need clarification
If you find a problem
- Post a comment on the bug with details (preferably including patch!)
- Reopen the bug
- If it looks like the original developer isn't seeing it, reassign to Eloy Lafuente for triage
- If the fix is obvious and you have CVS access, fix it yourself
Mark the fix as reviewed
- When you are satisfied the bug is correctly fixed, simply change the status from Resolved to Closed
- If you committed any fix, let somebody else review it again - do not Close it yourself
Every Wednesday
- The download site will automatically tag the whole current stable codebase (eg MOODLE_19_WEEKLY) and then build download packages
See also
- Using Moodle Tuesday Code Reviews forum discussion
