Weekly Code Review: Difference between revisions
From MoodleDocs
No edit summary |
|||
| Line 5: | Line 5: | ||
==Every Tuesday== | ==Every Tuesday== | ||
Everyone should look at | Everyone should look at the latest bugs needing review: | ||
Moodle 1.9 stable: [http://tracker.moodle.org/secure/IssueNavigator.jspa?mode=hide&requestId=10565 1.9.x Needs QA review] | |||
(Make sure you can see the QA Assigned column) | (Make sure you can see the QA Assigned column) | ||
Grab any bug | Grab any bug that: | ||
* is from the last week | |||
* you did not fix | |||
* does not have a QA assignee yet | |||
and claim it by editing the bug to add your name as QA Assignee. | |||
| Line 17: | Line 25: | ||
* Look at the patch atatched to the tracker | * Look at the patch atatched to the tracker | ||
* Try the feature out to make sure it works as advertised | * Try the feature out to make sure it works as advertised | ||
* Post new comments if you need clarification | * Post new comments (or talk on Moodle HQ) if you need clarification | ||
| Line 23: | Line 31: | ||
* When you are satisfied, simply change the status from Resolved to Closed | * When you are satisfied, simply change the status from Resolved to Closed | ||
==Every Wednesday== | ==Every Wednesday== | ||
* The download site will automatically tag the whole current stable codebase (eg MOODLE_19_WEEKLY) and then build download packages | * The download site will automatically tag the whole current stable codebase (eg MOODLE_19_WEEKLY) and then build download packages | ||
Revision as of 03:20, 1 April 2008
Moodle has a weekly process of code review in the stable branches to help improve the quality of stable packages and to help detect any regressions that may have occurred in stable code.
Here is the process for testers and developers:
Every Tuesday
Everyone should look at the latest bugs needing review:
Moodle 1.9 stable: 1.9.x Needs QA review
(Make sure you can see the QA Assigned column)
Grab any bug that:
- is from the last week
- you did not fix
- does not have a QA assignee yet
and claim it by editing the bug to add your name as QA Assignee.
Test the fix
- Read the comments
- Look at the patch atatched to the tracker
- Try the feature out to make sure it works as advertised
- Post new comments (or talk on Moodle HQ) if you need clarification
Mark the fix as reviewed
- When you are satisfied, simply change the status from Resolved to Closed
Every Wednesday
- The download site will automatically tag the whole current stable codebase (eg MOODLE_19_WEEKLY) and then build download packages
